[charts] Fix Tooltip crash with out of range lines #11898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfauquette
added
bug 🐛
alexfauquette
added
the
needs cherry-pick
|
Deploy preview: https://deploy-preview-11898--material-ui-x.netlify.app/ |
LukasTy
approved these changes
Feb 1, 2024
Comment on lines
36
to
39
| {series | ||
| .filter((item): item is ChartSeriesDefaultized<CartesianChartSeriesType> => | ||
| ['bar', 'line', 'scatter'].includes(item.type), | ||
| ) |
There was a problem hiding this comment.
Nitpick: WDYT, would it make sense to extract it into a variable outside of JSX? 🤔
There was a problem hiding this comment.
Very good idea. I also did it for the container
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11893
If some series stop earlier, the default tooltip called the formatter with
undefinedwhich was no handled by the default formatter.I tried to improve the typing, but not that much a success