Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Integrate changes from Core's #40842 #11801

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Jan 24, 2024

Includes changes necessary to include code from mui/material-ui#40842

It changes usage of @mui-internal/docs-utils and @mui-internal/typescript-to-proptypes from monorepo to npm packages.

Note - as of Jan 29, these packages are not actually published to npm - this PR uses the Codesandbox CI artifacts. I'll push them to npm when I'm certain they work. The packages are published to npm.

@michaldudak michaldudak added the scope: code-infra Specific to the core-infra product label Jan 24, 2024
@mui-bot
Copy link

mui-bot commented Jan 24, 2024

Deploy preview: https://deploy-preview-11801--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 3d37f46

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 24, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@michaldudak michaldudak force-pushed the core-integration/40757 branch from 0f354ee to 1192258 Compare January 25, 2024 08:34
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 25, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 26, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 26, 2024
@michaldudak michaldudak force-pushed the core-integration/40757 branch from 1dd2a00 to f5fc149 Compare January 29, 2024 13:47
@michaldudak michaldudak changed the title [code-infra] Integrate changes from Core's #40757 [code-infra] Integrate changes from Core's #40842 Jan 29, 2024
@michaldudak michaldudak force-pushed the core-integration/40757 branch from f5fc149 to c60b755 Compare January 29, 2024 13:53
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 30, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@michaldudak michaldudak force-pushed the core-integration/40757 branch from c60b755 to f07205b Compare February 2, 2024 08:03
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 2, 2024
@michaldudak michaldudak force-pushed the core-integration/40757 branch from f07205b to de69648 Compare February 2, 2024 08:17
@michaldudak michaldudak force-pushed the core-integration/40757 branch from 2e9341d to cc240c3 Compare February 2, 2024 09:15
@michaldudak michaldudak marked this pull request as ready for review February 2, 2024 09:39
@michaldudak michaldudak requested review from flaviendelangle and a team February 2, 2024 09:39
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍
Great work and congrats on releasing the first internal packages! 🚀 💯

@michaldudak michaldudak merged commit 57c6f9d into mui:next Feb 2, 2024
17 checks passed
@michaldudak michaldudak deleted the core-integration/40757 branch February 2, 2024 10:45
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants