Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TreeView] Make each plugin responsible for its context value #11623

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Jan 9, 2024

Extracted from #11452

The idea here is to have each plugin decide what to pass to the context and to type it.

@flaviendelangle flaviendelangle self-assigned this Jan 9, 2024
@flaviendelangle flaviendelangle added the component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module! label Jan 9, 2024
@mui-bot
Copy link

mui-bot commented Jan 9, 2024

Deploy preview: https://deploy-preview-11623--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 94816ea

Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE work!!! 🚀

@@ -8,6 +8,14 @@ export type DefaultizedProps<
Required<Pick<P, RequiredProps>> &
AdditionalProps;

type IsAny<T> = 0 extends 1 & T ? true : false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found that one on Stackoverflow 😆

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to read an explanation article about it to understand that! :D

@flaviendelangle flaviendelangle merged commit 58d50ad into mui:next Jan 12, 2024
17 checks passed
@flaviendelangle flaviendelangle deleted the context-tree-view branch January 12, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tree view TreeView, TreeItem. This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants