-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TreeView] Make each plugin responsible for its context value #11623
Conversation
Deploy preview: https://deploy-preview-11623--material-ui-x.netlify.app/ |
1af0920
to
5416edb
Compare
5416edb
to
f774f73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE work!!! 🚀
@@ -8,6 +8,14 @@ export type DefaultizedProps< | |||
Required<Pick<P, RequiredProps>> & | |||
AdditionalProps; | |||
|
|||
type IsAny<T> = 0 extends 1 & T ? true : false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NICE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found that one on Stackoverflow 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to read an explanation article about it to understand that! :D
Extracted from #11452
The idea here is to have each plugin decide what to pass to the context and to type it.