Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DateCalendar] Remove the string argument of the dayOfWeekFormatter prop #10992

Merged
merged 12 commits into from
Nov 16, 2023
Merged

[DateCalendar] Remove the string argument of the dayOfWeekFormatter prop #10992

merged 12 commits into from
Nov 16, 2023

Conversation

flaviendelangle
Copy link
Member

Closes #10991

@flaviendelangle flaviendelangle self-assigned this Nov 10, 2023
@flaviendelangle flaviendelangle added breaking change component: pickers This is the name of the generic UI component, not the React module! v7.x labels Nov 10, 2023
@mui-bot
Copy link

mui-bot commented Nov 10, 2023 •
edited
Loading

Deploy preview: https://deploy-preview-10992--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 8155cfd

@flaviendelangle flaviendelangle changed the title [DateCalendar] Remove the string argument of the dayOfWeekFormatter prop [DateCalendar] Remove the string argument of the dayOfWeekFormatter prop Nov 10, 2023
@flaviendelangle flaviendelangle marked this pull request as ready for review November 10, 2023 11:31
michelengelen
michelengelen approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/data/migration/migration-pickers-v6/migration-pickers-v6.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 10, 2023
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 10, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 13, 2023
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Nov 13, 2023
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 14, 2023
alexfauquette
alexfauquette approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think it is worth a codemod.

I proposed picky modification of the breaking change. Not sure either they are an improvement or not

docs/data/migration/migration-pickers-v6/migration-pickers-v6.md Outdated Show resolved Hide resolved
docs/data/migration/migration-pickers-v6/migration-pickers-v6.md Outdated Show resolved Hide resolved
flaviendelangle and others added 2 commits November 15, 2023 19:46
@flaviendelangle @alexfauquette
Update docs/data/migration/migration-pickers-v6/migration-pickers-v6.md
f4ff177 
Co-authored-by: Alexandre Fauquette <[email protected]>
Signed-off-by: Flavien DELANGLE <[email protected]>
@flaviendelangle @alexfauquette
Update docs/data/migration/migration-pickers-v6/migration-pickers-v6.md
8155cfd 
Co-authored-by: Alexandre Fauquette <[email protected]>
Signed-off-by: Flavien DELANGLE <[email protected]>
@flaviendelangle flaviendelangle merged commit b5585d0 into mui:next Nov 16, 2023
5 checks passed
@flaviendelangle flaviendelangle deleted the dayOfWeekFormatter-bc branch November 16, 2023 09:00
@LukasTy LukasTy mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

@michelengelen michelengelen michelengelen approved these changes

@LukasTy LukasTy Awaiting requested review from LukasTy

Assignees

@flaviendelangle flaviendelangle

Labels
breaking change component: pickers This is the name of the generic UI component, not the React module! v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pickers] v7: Remove the string argument of the dayOfWeekFormatter prop
4 participants
@flaviendelangle @mui-bot @michelengelen @alexfauquette