[docs] Use Base UI Portal for the quick filter recipe
#10188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Netlify deploy previewNetlify deploy preview: https://deploy-preview-10188--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
MBilalShafi
approved these changes
Sep 4, 2023
| <GridToolbarQuickFilter />, | ||
| document.getElementById('filter-panel'), | ||
| )} | ||
| <Portal container={() => document.getElementById('filter-panel')}> |
There was a problem hiding this comment.
Is using the function-based selector needed here, could we directly use the selector here?
Suggested change
| <Portal container={() => document.getElementById('filter-panel')}> | |
| <Portal container={document.getElementById('filter-panel')}> |
As per docs:
There was a problem hiding this comment.
It would break during server side rendering, I guess.
| <GridToolbarQuickFilter />, | ||
| document.getElementById('filter-panel')!, | ||
| )} | ||
| <Portal container={() => document.getElementById('filter-panel')}> |
There was a problem hiding this comment.
I have doubt about the types in https://github.com/mui/material-ui/blob/ffa4751a513cee56a8cd069c788a209d8beae7c7/packages/mui-base/src/Portal/Portal.types.ts#L15. This feels so strange. Why should it allow <Portal container={() => null}>
Suggested change
| <Portal container={() => document.getElementById('filter-panel')}> | |
| <Portal container={() => document.getElementById('filter-panel')!}> |
| <GridToolbarQuickFilter />, | ||
| document.getElementById('filter-panel'), | ||
| )} | ||
| <Portal container={() => document.getElementById('filter-panel')}> |
There was a problem hiding this comment.
It would break during server side rendering, I guess.
….tsx Co-authored-by: Olivier Tassinari <[email protected]> Signed-off-by: Danail Hadjiatanasov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #10121 (comment)