Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Disable false positive e2e test on webkit #10187

Merged

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Aug 31, 2023

@LukasTy LukasTy added the test label Aug 31, 2023
@LukasTy LukasTy self-assigned this Aug 31, 2023
@LukasTy LukasTy requested review from a team August 31, 2023 09:44
@mui-bot
Copy link

mui-bot commented Aug 31, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-10187--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms -161.9 160.1 160.1 1.12 121.437
Sort 100k rows ms 847.1 1,730 1,630.6 1,407.7 307.504
Select 100k rows ms 762.8 918.8 851.5 853.34 53.865
Deselect 100k rows ms 139.8 384.7 206.2 234.26 81.672

Generated by 🚫 dangerJS against 19268ec

Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is odd, I cannot make this test fail in Webkit locally 🙃

@LukasTy
Copy link
Member Author

LukasTy commented Aug 31, 2023

This is odd, I cannot make this test fail in Webkit locally 🙃

Same here, but it does occasionally on CI...
Even setting a higher global timeout did not seem to help. 🙈

@LukasTy LukasTy merged commit 85969cb into mui:master Aug 31, 2023
@LukasTy LukasTy deleted the disable-false-positive-e2e-test-on-webkit branch August 31, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants