Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add DemoContainer and DemoItem JSDoc #10186

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Aug 31, 2023

Fixes #10106

Apply the least intrusive improvement of adding a JSDoc explaining the intent of these components.
I'm not sure we should start renaming the components and possibly causing even more confusion at this stage. 🤔 🤷

@LukasTy LukasTy added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature labels Aug 31, 2023
@LukasTy LukasTy self-assigned this Aug 31, 2023
@mui-bot
Copy link

mui-bot commented Aug 31, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-10186--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms -159.9 114.6 114.6 6.66 114.423
Sort 100k rows ms 866.8 1,487.4 1,449.7 1,324.38 230.946
Select 100k rows ms 696.2 877.5 802.8 787.14 64.073
Deselect 100k rows ms 127.8 317.7 187.4 201.58 62.513

Generated by 🚫 dangerJS against 9306859

@LukasTy LukasTy merged commit 6d71475 into mui:master Aug 31, 2023
@LukasTy LukasTy deleted the add-demo-components-jsdoc branch August 31, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pickers]: Unexpected error on pickers
3 participants