[DataGrid] Refactor: replace timeout with useTimeout #10179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romgrk
added
the
component: data grid
Netlify deploy previewNetlify deploy preview: https://deploy-preview-10179--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
romgrk
commented
Aug 31, 2023
Comment on lines
-136
to
+135
| [scrollDirection, apiRef], | ||
| [scrollDirection, apiRef, timeout], |
There was a problem hiding this comment.
One thing I don't like is that eslint doesn't recognize useTimeout as a React ref, so it requires this.
There is a react issue for this but it's been open forever: facebook/react#16873
There was a problem hiding this comment.
I think it's fine, especially with the ESlint auto-fix turned on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of
useTimeoutto declutter a bit.NOTE: AUTO-MERGE ENABLED, only approve if this is good to go.