Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Fix custom column docs, remove legacy extendType #10175

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 30, 2023

As I understand it, this property has no effect since #7309. I have noticed the issue looking at a date formatting issue with Toolpad: https://github.com/mui/mui-toolpad/blob/32d14b33cd296b204a1ce9b3199035524bd751db/packages/toolpad-components/src/DataGrid.tsx#L285

But the docs look wrong too: https://mui.com/x/react-data-grid/filtering/customization/#custom-column-types.

@oliviertassinari oliviertassinari added component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature docs Improvements or additions to the documentation and removed enhancement This is not a bug, nor a new feature labels Aug 30, 2023
@oliviertassinari oliviertassinari changed the title [DataGrid] Remove legacy extendType property [DataGrid] Fix custom column docs, remove legacy extendType property Aug 30, 2023
@oliviertassinari oliviertassinari changed the title [DataGrid] Fix custom column docs, remove legacy extendType property [DataGrid] Fix custom column docs, remove legacy extendType Aug 30, 2023
@mui-bot
Copy link

mui-bot commented Aug 30, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-10175--material-ui-x.netlify.app/

Updated pages

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms -209 -71.9 -209 -136.36 53.37
Sort 100k rows ms 655.9 1,375.6 1,350.3 1,183.52 267.742
Select 100k rows ms 684.2 819.4 709.2 741.56 53.356
Deselect 100k rows ms 134.4 213.2 200.2 186.32 27.708

Generated by 🚫 dangerJS against 6b43d4f

Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, thanks for spotting this!

@oliviertassinari oliviertassinari merged commit 5c74c37 into mui:master Aug 31, 2023
4 checks passed
@oliviertassinari oliviertassinari deleted the remove-extendType branch August 31, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants