Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Grid2] Add container styles from styleOverrides #44598

Merged
merged 6 commits into from
Nov 30, 2024
Merged

[Grid2] Add container styles from styleOverrides #44598

merged 6 commits into from
Nov 30, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Nov 29, 2024 •
edited by ZeeshanTamboli
Loading

@sai6855 sai6855 added bug 🐛 Something doesn't work component: Grid The React component. labels Nov 29, 2024
@sai6855 sai6855 marked this pull request as draft November 29, 2024 07:28
@mui-bot
Copy link

mui-bot commented Nov 29, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-44598--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against e11e84a

@sai6855 sai6855 marked this pull request as ready for review November 29, 2024 08:20
@ZeeshanTamboli ZeeshanTamboli added package: material-ui Specific to @mui/material regression A bug, but worse labels Nov 30, 2024
ZeeshanTamboli
ZeeshanTamboli approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same is the case with the deprecated Grid component, but since it is deprecated let's not fix it. This looks good.

@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Nov 30, 2024
Merged
@sai6855 sai6855 merged commit 452d971 into mui:master Nov 30, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeeshanTamboli ZeeshanTamboli ZeeshanTamboli approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: Grid The React component. package: material-ui Specific to @mui/material regression A bug, but worse
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sai6855 @mui-bot @ZeeshanTamboli