[core-infra] Remove useless fragments #44516
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
oliviertassinari
force-pushed
the
remove-noise-fragment
branch
from
831073b
to
c35a00d
Compare
Netlify deploy previewhttps://deploy-preview-44516--material-ui.netlify.app/ PigmentHidden: parsed: +2.29% , gzip: +2.84% Bundle size reportDetails of bundle changes (Toolpad) |
oliviertassinari
force-pushed
the
remove-noise-fragment
branch
from
36103ee
to
16b8868
Compare
| @@ -628,58 +628,59 @@ export default async function generateComponentApi( | |||
| const filename = componentInfo.filename; | |||
| let reactApi: ComponentReactApi; | |||
|
|
|||
| if (componentInfo.isSystemComponent || componentInfo.name === 'Grid2') { | |||
There was a problem hiding this comment.
That hard-coded logic felt wrong, we further added stuff around it in 08dce48#diff-eef575d465fe9894710e7eb399c76ad3e3900a8cbb6d374be7f303c4b6c6ef51R627
romgrk
approved these changes
Nov 25, 2024
|
It's related to code-infra, right, I wasn't sure who to ask. This will impact Base UI too, e.g. we should be able to simplify NoSsr implementation. Let's ask Michal for a review, I guess it's the closest. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm having some fun with the AST, allowing https://github.com/reactjs/react-docgen to extract props descriptions even when the component doesn't return a React element. We shouldn't be shipping dead code to developers, this PR avoids this. This should both improve bundle size and runtime.
DefinitelyTyped/DefinitelyTyped#65135 should help in the future.