Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[website] Open the xCharts, eXplore and X general react engineer roles #43805

Merged
merged 23 commits into from
Sep 25, 2024
Merged

[website] Open the xCharts, eXplore and X general react engineer roles #43805

merged 23 commits into from
Sep 25, 2024

Conversation

DanailH
Copy link
Member

@DanailH DanailH commented Sep 18, 2024 •
edited by oliviertassinari
Loading

@DanailH DanailH added the website Pages that are not documentation-related, marketing-focused. label Sep 18, 2024
@DanailH DanailH requested a review from a team September 18, 2024 11:21
@DanailH DanailH self-assigned this Sep 18, 2024
@mui-bot
Copy link

mui-bot commented Sep 18, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43805--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against bab8f6e

oliviertassinari
oliviertassinari reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a bunch of changes, it looks great on my end. I want to make more changes to this page, but for the sake of being iterative, kept it to the low hanging fruits.

@DanailH
Copy link
Member Author

DanailH commented Sep 18, 2024

I pushed a bunch of changes, it looks great on my end. I want to make more changes to this page, but for the sake of being iterative, kept it to the low hanging fruits.

Thank you @oliviertassinari for doing those changes!

@DanailH DanailH merged commit 36932f1 into mui:master Sep 25, 2024
22 checks passed
@DanailH
Copy link
Member Author

DanailH commented Sep 25, 2024

I synced it with Ashby before merging.

@aarongarciah aarongarciah mentioned this pull request Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@Janpot Janpot Awaiting requested review from Janpot

Assignees

@DanailH DanailH

Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanailH @mui-bot @Janpot @oliviertassinari