[codemod] Fix codemod crash on MuiDivider property (#43125)

mui · Aug 1, 2024 · 0ed7c11 · 0ed7c11
1 parent edc6d61
commit 0ed7c11
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 32 deletions.
diff --git a/packages/mui-codemod/src/deprecations/divider-props/divider-props.js b/packages/mui-codemod/src/deprecations/divider-props/divider-props.js
@@ -1,6 +1,7 @@
 import appendAttribute from '../../util/appendAttribute';
 import assignObject from '../../util/assignObject';
 import findComponentJSX from '../../util/findComponentJSX';
+import findComponentDefaultProps from '../../util/findComponentDefaultProps';
 
 /**
  * @param {import('jscodeshift').FileInfo} file
@@ -61,47 +62,36 @@ export default function transformer(file, api, options) {
     }
   });
 
-  root.find(j.ObjectProperty, { key: { name: 'MuiDivider' } }).forEach((path) => {
-    const defaultPropsObject = path.value.value.properties.find(
-      (key) => key.key.name === 'defaultProps',
-    );
+  const defaultPropsPathCollection = findComponentDefaultProps(j, {
+    root,
+    componentName: 'Divider',
+  });
 
-    const lightProp = defaultPropsObject.value.properties.find((prop) => prop.key.name === 'light');
+  defaultPropsPathCollection.find(j.ObjectProperty, { key: { name: 'light' } }).forEach((path) => {
+    const { properties: defaultPropsProperties } = path.parent.value;
 
-    if (!lightProp) {
+    if (path.value?.value.value === false) {
+      path.prune();
       return;
     }
 
-    defaultPropsObject.value.properties = defaultPropsObject.value.properties.filter(
-      (prop) => !['light'].includes(prop?.key?.name),
-    );
-
-    const isLightPropTruthy = lightProp.value?.value !== false;
-
-    if (!isLightPropTruthy) {
-      return;
-    }
+    const existingSx = defaultPropsProperties.find((prop) => prop.key.name === 'sx');
 
-    const sxIndex = defaultPropsObject.value.properties.findIndex((prop) => prop.key.name === 'sx');
-
-    if (sxIndex === -1) {
-      defaultPropsObject.value.properties.push(
-        j.objectProperty(
+    if (!existingSx) {
+      defaultPropsProperties.push(
+        j.property(
+          'init',
           j.identifier('sx'),
           j.objectExpression([j.objectProperty(j.identifier('opacity'), j.literal('0.6'))]),
         ),
       );
-    } else {
-      const opacityIndex = defaultPropsObject.value.properties[sxIndex].value.properties.findIndex(
-        (key) => key.key.name === 'opacity',
+    } else if (!existingSx.value.properties.find((prop) => prop.key.name === 'opacity')) {
+      existingSx.value.properties.push(
+        j.property('init', j.identifier('opacity'), j.literal('0.6')),
       );
-
-      if (opacityIndex === -1) {
-        defaultPropsObject.value.properties[sxIndex].value.properties.push(
-          j.objectProperty(j.identifier('opacity'), j.literal('0.6')),
-        );
-      }
     }
+
+    path.prune();
   });
 
   return root.toSource(printOptions);

diff --git a/packages/mui-codemod/src/deprecations/divider-props/test-cases/theme.actual.js b/packages/mui-codemod/src/deprecations/divider-props/test-cases/theme.actual.js
@@ -65,3 +65,9 @@ fn({
     },
   },
 });
+fn({
+  MuiDivider: {},
+});
+fn({
+  MuiDivider: 123,
+});
diff --git a/packages/mui-codemod/src/deprecations/divider-props/test-cases/theme.expected.js b/packages/mui-codemod/src/deprecations/divider-props/test-cases/theme.expected.js
@@ -15,27 +15,29 @@ fn({
     defaultProps: {
       sx: {
         opacity: "0.6"
-      },
+      }
     },
   },
 });
 fn({
   MuiDivider: {
     defaultProps: {
       className: 'my-class',
+
       sx: {
         opacity: "0.6"
-      },
+      }
     },
   },
 });
 fn({
   MuiDivider: {
     defaultProps: {
       className: 'my-class',
+
       sx: {
         opacity: "0.6"
-      },
+      }
     },
   },
 });
@@ -69,3 +71,9 @@ fn({
     },
   },
 });
+fn({
+  MuiDivider: {},
+});
+fn({
+  MuiDivider: 123,
+});