Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#623: Add drag and drop priority sorting to legacy Administration Interface #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ernestob
Copy link
Member

Our long term clients were used to some of the functionality provided by the admin2++ extension.

The most requested feature is the drag and drop priority sorting.
This pull request is bringing back that feature.

https://jira.ez.no/browse/EZP-30155

@pkamps
Copy link
Member

pkamps commented Mar 10, 2019

Hi Ernesto,

there is some caching issue:

  • In a folder, create 11 subitems
  • Sort them by priority
  • Drag the first item to the bottom of the list
  • You patch will set the correct priorities
  • Then click on page 2 in the bottom pagination
  • Click back to page 1
  • You will see the outdated priority sorting and you do not see changes from before (first item now last)
  • That's not the case if you change the priority by typing in a priority value
  • Let me know if that makes sense or if you need a quick demo

@ernestob
Copy link
Member Author

This is good, thanks.

First, I will try to reproduce that issue.

@pkamps
Copy link
Member

pkamps commented Mar 13, 2019

There are probably other use cases that break on multi-page sub items listing. Maybe we only allow the drag&drop on nodes that can show all subitems (so max 10-20-50 items).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants