Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Makefile and make.py script #1959

Merged
merged 2 commits into from
Feb 12, 2022
Merged

Update Makefile and make.py script #1959

merged 2 commits into from
Feb 12, 2022

Conversation

carlosperate
Copy link
Member

@carlosperate carlosperate commented Dec 28, 2021 •
edited
Loading

  • Completes make.py docs command
  • Adds more entries to make.py clean from the Makefile.
  • Invokes python modules explicitly via the Python interpreter, i.e. python -m black ... instead of black ...
    • In some situations, like pip installing in a user environment without sudo, the installed packages like black or flake don't have their entry point added to PATH.
    • It's also more robust to make sure it's always calling this Python environment module instead of something else with precedence in the PATH
    • This is also needed for running additional tests in CI: PR CI: Add Arm Raspbian job that installs Mu in system Python. #1960

@carlosperate
make: Invoke python modules explicity via Python interpreter.
68d24d0 
In some situations, like pip installing in a user environment without
sudo, the installed packages like black or flake don't have their
entry point added to PATH.

Using "python -m black ..." instead ensures the commands can always
be launched.

It's also more robust to make sure it's always calling this Python
environment module instead of something else with precedence in
the PATH
@carlosperate
make: Complete make.py docs command, and update clean.
6236d74
@carlosperate carlosperate mentioned this pull request Dec 28, 2021
Draft
@ntoll ntoll merged commit c653806 into master Feb 12, 2022
@carlosperate carlosperate deleted the make branch February 14, 2022 12:53
@carlosperate carlosperate added this to the 1.1-final milestone Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1-final
Development

Successfully merging this pull request may close these issues.
2 participants
@carlosperate @ntoll