Avoid KernelManager.pre_start_kernel. Use kernel spec for the REPL instead. #1927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to a discussion in #1517:
KernelManager.pre_start_kernel()
, added in #1240, is not compatible with old versions ofjupyter_client
and is actively causing crashes for our users.This PR removes the subclassing of
QtKernelManager
andpre_start_kernel()
. It uses a kernel spec, which has to be saved to disk, to pass the correct interpreter tojupyter_client
.The whole design is up for discussion. One issue might be persisting invalid specs, because currently it's only created on disk if no kernel exists with the same name we'd use.