Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling from plug-surfaced errors #342

Merged
merged 4 commits into from
Apr 21, 2024
Merged

Improve error handling from plug-surfaced errors #342

merged 4 commits into from
Apr 21, 2024

Conversation

mtrudel
Copy link
Owner

@mtrudel mtrudel commented Apr 19, 2024 •
edited
Loading

  • HTTP/1 stack respects Plug.Exception error implementations
  • HTTP/2 stack respects Plug.Exception error implementations
  • Bandit.HTTPError error codes implemented using Plug.Exception conventions
  • Logging made conditional on an exception's Plug.Exception sourced status code
  • Ensure HTTP/1 connections are closed on error for safety

@mtrudel mtrudel force-pushed the plug_exception_awareness branch 3 times, most recently from 6674672 to 0042fa5 Compare April 19, 2024 18:57
@mtrudel mtrudel force-pushed the plug_exception_awareness branch 2 times, most recently from cbdc44a to 1104082 Compare April 19, 2024 19:46
@mtrudel mtrudel merged commit 2c8b888 into main Apr 21, 2024
27 checks passed
@mtrudel mtrudel deleted the plug_exception_awareness branch April 21, 2024 13:04
@mtrudel mtrudel mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mtrudel