Migration dialog was not usable on phone, due to missing scroll modifier

mtotschnig · Aug 17, 2024 · 211da4d · 211da4d
1 parent 3726828
commit 211da4d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/fints/src/main/java/org/totschnig/fints/Banking.kt b/fints/src/main/java/org/totschnig/fints/Banking.kt
@@ -334,8 +334,7 @@ class Banking : ProtectedFragmentActivity() {
                     },
                     text = {
                         Column(
-                            modifier = Modifier
-                                .verticalScroll(rememberScrollState())
+                            modifier = Modifier.verticalScroll(rememberScrollState())
                         ) {
                             Error(errorMessage = errorState.value)
                             Help(buildList {

diff --git a/fints/src/main/java/org/totschnig/fints/Composables.kt b/fints/src/main/java/org/totschnig/fints/Composables.kt
@@ -9,10 +9,12 @@ import androidx.compose.foundation.layout.ColumnScope
 import androidx.compose.foundation.layout.Row
 import androidx.compose.foundation.layout.fillMaxWidth
 import androidx.compose.foundation.layout.width
+import androidx.compose.foundation.rememberScrollState
 import androidx.compose.foundation.selection.selectable
 import androidx.compose.foundation.selection.selectableGroup
 import androidx.compose.foundation.text.KeyboardActions
 import androidx.compose.foundation.text.KeyboardOptions
+import androidx.compose.foundation.verticalScroll
 import androidx.compose.material.icons.Icons
 import androidx.compose.material.icons.filled.AccountBalance
 import androidx.compose.material3.AlertDialog
@@ -341,7 +343,10 @@ fun MigrationDialog(
                 }
             },
             text = {
-                Column(verticalArrangement = Arrangement.spacedBy(4.dp)) {
+                Column(
+                    modifier = Modifier.verticalScroll(rememberScrollState()),
+                    verticalArrangement = Arrangement.spacedBy(4.dp)
+                ) {
                     Text(stringResource(R.string.migration_description_1548))
 
                     Error((migrationState as? MigrationState.Failure)?.message)