Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require comma delimiters for exec form #117

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Do not require comma delimiters for exec form #117

merged 1 commit into from
Oct 18, 2024

Conversation

mthalman
Copy link
Owner

In order to better facilitate parsing of the output from the docker history command, it's necessary to loosen the requirements of parsing exec form instructions such as CMD.

As an example, a Dockerfile containing the instruction CMD ["echo", "Hello"] will be represented as CMD ["echo" "Hello"] in the output of the docker history command (notice the lack of a comma). So it's not truly a valid JSON array syntax.

This updates the parsing logic to allow the comma to be optional in this case.

@mthalman mthalman merged commit c031efe into main Oct 18, 2024
1 check passed
@mthalman mthalman deleted the exec-form branch October 18, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant