-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 7493: Add credit cost of cards alongside their names and influence in deck builder #7829
Conversation
looks great. This should be toggleable from within the deckbuilder, defaulting to off. |
@NoahTheDuke Sounds good, thoughts on any other costs such as memory cost or advancement requirement that would be useful to see inline? |
I don't know how you'd include that without making it look incredibly messy. I already have reservations about showing credit cost which is why I suggested defaulting to off. You're welcome to try it out tho, we can see the results and discuss. |
@NoahTheDuke make sense to me, I just thought if we were already making toggle-able views its worth considering other relevant information for the sake of conversation, here is what it might look like |
That's looking pretty neat. I think having a toggle for each might be nice. I also wonder if we might be better served with the metadata being right-aligned (like a table) for readability (influence is probably fine where it is, since it's only active on 2-3 cards usually, and the number is the unit - but costs/mu are active on all of them, and include a unit too, so it looks less tidy) |
@NBKelly by right-aligned do you mean to the right of influence or fully alighted to the right side of the container? I think that would be harder to read. Since cost would be present on cards, if we moved the costs to the right of influence on toggle it would end up like
whereas in the current state of this feature it would be
I think the latter would be easier to read. Thoughts? |
Something like
That's entirely my preference though, you don't need to do that if you don't like it. |
@NBKelly i'll draft up both and ask some friends to see if they have any preference. I sometimes find myself highlighting lines on webpages when there is text floating out in space. for now i'll work on the toggle and let you know what it looks like! |
The cool thing about it is that with the css config i have here, it does not affect vertical distance at all when toggling it on and off, so it just appears/disappears inline and doesnt break up the visual |
That's looking pretty damn neat, good work. The "highlight" on mouseover is actually pretty sick too, I say keep it if you like it. |
another thing that came up while working on this - if the hover background seems like a good add, maybe hovering over the the div could select that card and pin the card preview on the top right corner of the screen like on the gameboard. I wrote this down in my list of feature ideas at least |
@NBKelly thank you!! glad you like it. Going to double check the code here to make sure I dont have print statments etc, but both of my open PRs are review ready as far as logic goes. |
cleaned code updated PR description ready for review |
tbh this is great, much better than i thought it would be. thanks for the effort |
Thanks 😁 Glad to help out |
Hello,
This PR contains an initial implementation of #7493
Closes #7493
This PR adds the credit/mu cost of applicable cards to the Deck Builder
decklist
panelDescription of change:
decklist
moduleline
indecklist
Methodology:
Considerations and potential next steps:
fake-link
functionality to a larger area for hoveringCards
could be a cool toggle for a fully integrated deckbuilding experience in one tab