Allow cutting down Ethereal bamboo with chainsaw #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emojigit
force-pushed
the
fork-20241227-bamboo-chainsaw
branch
from
a4ade3d to
c8c6407
Compare
|
Does ethereal bamboo really need to be cut with chainsaw? It seems to work like papyrus where all the nodes are removed automatically when the base is dug: https://codeberg.org/tenplus1/ethereal/src/branch/master/wood.lua#L324-L326 |
|
Yeah, they are removed when removing their base. However, not able to use the chainsaw on bamboo confuses the users (at least one on my server) as bamboo behaves like trees (having trunks and leaves). |
OgelGames
reviewed
Dec 27, 2024
Adds `ethereal:bamboo` into `timber_nodenames`. This PR is ready for review.
Emojigit
force-pushed
the
fork-20241227-bamboo-chainsaw
branch
from
c8c6407 to
caf8497
Compare
OgelGames
approved these changes
Dec 27, 2024
BuckarooBanzay
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ethereal:bamboointotimber_nodenames.This PR is ready for review.