Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

technic:motor to basic_materials:motor #333

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

nonfreegithub
Copy link
Contributor

@nonfreegithub nonfreegithub commented Nov 3, 2023

technic:motor does not exist, technic requires basic_materials, which adds the alias technic:motor to basic_materials:motor

basic_materials:motor is used in other crafts

technic:motor does not exist, technic requires basic_materials, which adds the alias technic:motor to basic_materials:motor

basic_materials:motor is used in other crafts
Copy link

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@wsor4035
Copy link

wsor4035 commented Nov 3, 2023

@S-S-X
Copy link
Member

S-S-X commented Nov 4, 2023

Any other mods known that also registers it?

edit. found this for one: minetest.register_alias("technic:motor", "homedecor:motor")
Could be good to check around a bit and see if this breaks some stuff and see if anything could be done easily. Current alias offers some freedom for bit wider use cases but still doesn't exactly look that good.

@wsor4035
Copy link

wsor4035 commented Nov 4, 2023

Any other mods known that also registers it?

edit. found this for one: minetest.register_alias("technic:motor", "homedecor:motor") Could be good to check around a bit and see if this breaks some stuff and see if anything could be done easily. Current alias offers some freedom for bit wider use cases but still doesn't exactly look that good.

doesnt really matter, all the rest of this mod are in the proper itemname form. see my edited comment. additionally your homedecor:motor is moot as well https://github.com/mt-mods/basic_materials/blob/e4a122dfdd991f5a3af27c9a84418fddf22fad49/aliases.lua#L12C1-L12C1

@wsor4035
Copy link

wsor4035 commented Nov 4, 2023

https://content.minetest.net/zipgrep/065bc1c5-7fc0-40ce-ac9f-e7e68c73e750/ technic:motor, nothing worth caring about
https://content.minetest.net/zipgrep/12a2ed1f-3857-48b8-8240-a6ec75dddc54/ homedecor:motor, nothing worth caring about

@wsor4035 wsor4035 merged commit fc96135 into mt-mods:master Nov 4, 2023
6 checks passed
@Athozus Athozus added this to the 2.0.0 milestone Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants