Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underch mod marble compatibility #331

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

nonfreegithub
Copy link
Contributor

underch is a popular cave improvement mod that adds marble and marble bricks (same as technic) but also stairs, slabs, marble cobble, mossy marble cobble, etc.

I have seen some servers where both mods are used and I thought it would be good to add this little compatibility

underch is a popular cave improvement mod that adds marble and marble bricks (same as technic) but also stairs, slabs, marble cobble, mossy marble cobble, etc.

I have seen some servers where both mods are used and I thought it would be good to add this little compatibility
@OgelGames
Copy link
Contributor

Makes sense to me 👍

One small thing, the has_underch variables are only used once in each file, so I think it would be better just to use minetest.get_modpath("underch") where needed, rather than add those extra variables.

@OgelGames OgelGames added the Compatibility Aims to improve compatibility with something. label Oct 26, 2023
@nonfreegithub
Copy link
Contributor Author

I dont know if underch must be in optional_depends, it can cause circular depends issues

@BuckarooBanzay
Copy link
Member

I dont know if underch must be in optional_depends, it can cause circular depends issues

Should not be an issue, the technic mod isn't required in the underch mod:
https://gitlab.com/h2mm/underch/-/blob/master/mod.conf?ref_type=heads

@BuckarooBanzay BuckarooBanzay merged commit ab43bf9 into mt-mods:master Oct 26, 2023
6 checks passed
@Athozus Athozus added this to the 2.0.0 milestone Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compatibility Aims to improve compatibility with something.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants