Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caused the server to crash #139

Closed
wants to merge 1 commit into from

Conversation

VinAdmin
Copy link
Contributor

@VinAdmin VinAdmin commented Sep 9, 2024

Added a check for nil.
photo_2024-09-09_12-03-32

@OgelGames
Copy link
Contributor

This won't change anything, nil values are already cancelled out by the or 0, and it's not the value that is the problem anyway, it's the table index.

It looks like minetest.hash_node_position is returning NaN (not nil), which means the value passed to that function is the problem.

@OgelGames OgelGames added the invalid This doesn't seem right label Sep 9, 2024
@OgelGames OgelGames closed this Sep 9, 2024
@VinAdmin
Copy link
Contributor Author

VinAdmin commented Sep 9, 2024

After this fix, everything started working correctly.

@SwissalpS
Copy link
Contributor

I agree with OgelGames, it's the value in h that is causing the error.

The reason it worked for you after this patch must be somewhere else. Possibly entity._pos was invalid in the run that crashed your game.

Please try and find a reliable way to reproduce the crash situation.

(Side-note: seriously a screenshot of text?)

@VinAdmin
Copy link
Contributor Author

VinAdmin commented Sep 9, 2024

(Side-note: seriously a screenshot of text?)

Unfortunately, the log file was not saved.

I hoped that the error was not only mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants