Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code and registrations cleanup #101

Merged
merged 2 commits into from
Jan 14, 2024
Merged

code and registrations cleanup #101

merged 2 commits into from
Jan 14, 2024

Conversation

BuckarooBanzay
Copy link
Member

@BuckarooBanzay BuckarooBanzay commented Jan 12, 2024

contents of this PR:

  • proper luacheck ci
  • various import-cleanups
  • game-dependent materials are now exposed in pipeworks.materials
  • moved a big chunk of common functions from init.lua to common.lua
  • created a new directory for tube modules
  • added pipeworks.register_embedded_tube(nodename, opts) to be used in other mods

(sorry for the big PR, i originally wanted to make a PR for the elbow-tube but was distracted somehow 🤷)

just for fun (not included here)
pipeworks.register_embedded_tube(":pipeworks:mese_block_embedded_tube", {
	description = "Airtight mese embedded tube",
	base_texture = "default_mese_block.png",
	base_ingredient = "default:mese"
})

screenshot_20240112_140344

Copy link
Contributor

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i really would not like materials to be exposed. this should properly be done with a mod/library like sounds, since this code is already semi duplicated across our mods with homedecor, steel, here, at least

@BuckarooBanzay
Copy link
Member Author

i really would not like materials to be exposed. this should properly be done with a mod/library like sounds, since this code is already semi duplicated across our mods with homedecor, steel, here, at least

materials is now available in pipeworks only (via loadfile) 👍

Copy link
Contributor

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit

@wsor4035 wsor4035 merged commit 578e452 into master Jan 14, 2024
2 checks passed
@OgelGames OgelGames deleted the code-registrations-cleanup branch January 14, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code and other cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants