Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hasConfigurableGlobal): handle existing globals with undefined value #669

Conversation

Afsoon
Copy link
Contributor

@Afsoon Afsoon commented Oct 31, 2024

fix: #668

@Afsoon Afsoon force-pushed the fix/intercept-web-socket-when-web-socket-is-undefined branch from f8180f3 to 18a7492 Compare October 31, 2024 15:56
@kettanaito kettanaito changed the title fix(hasConfigurableGlobal): check if a global value is undefined or not fix(hasConfigurableGlobal): handle existing globals with undefined value Nov 3, 2024
Copy link
Member

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the tests, added the check for the root cause at hand (getter that returns undefined). Looks good now!

@kettanaito kettanaito merged commit f2ae132 into mswjs:main Nov 3, 2024
2 checks passed
@kettanaito
Copy link
Member

@Afsoon, thanks for addressing this! Welcome to the contributors 👋

@kettanaito
Copy link
Member

Released: v0.36.8 🎉

This has been released in v0.36.8!

Make sure to always update to the latest version (npm i @mswjs/interceptors@latest) to get the newest features and bug fixes.


Predictable release automation by @ossjs/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

globalThis.WebSocket is undefined and it can't be proxied.
2 participants