Rename JitdumpOrMarkerPath to ProcessSpecificPath, add aux_child to ExistingProcessRunner #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some preparatory stuff. coreclr can generate a "nettrace" file (essentially cross-platform ETW) from a run in two ways:
dotnet tracetool which attaches to a diagnostic port on an existing process and enables tracingA future PR that adds support for dotnet trace is going to use both of these; if it's launching a process, it'll use the environment variables, and if it's attaching to an existing process, it'll spin up a
dotnet tracechild. ExistingProcessLauncher learns about these aux children and knows how to kill them when tracing stops.this also renames
JitdumpOrMarkerPathtoProcessSpecificPath, because it now also includes nettrace files via the same mechanism.