Don't add markers for unknown ETW events #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you be happy if we just ignored UnLoad and Terminated? I think @jrmuizel likes to experiment with different xperf start settings and then it's convenient to just have the new markers show up immediately. |
|
Yeah, I was actually thinking of just adding a command line flag to make markers for unknown things, because it is pretty useful. Would that work? Specifically:
? I'd like an option instead of doing it unilaterally so that if I'm importing an etl file created elsewhere, it may contain lots of events that I don't care about at all, but may end up as a large volume of markers. |
vvuk
force-pushed
the
no-unknown-event-markers
branch
from
e373b72 to
5b612d8
Compare
vvuk
force-pushed
the
no-unknown-event-markers
branch
from
5b612d8 to
0b51cf6
Compare
|
Ok, reworked this to add the command line option; let me know if that works. |
mstange
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are useful for debugging and might be a nice command line option in the future, but for now they just add random
Image/UnLoadandProcess/Terminatedevents which aren't useful