Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle CoreCLR events #189

Merged
merged 5 commits into from
May 12, 2024
Merged

Handle CoreCLR events #189

merged 5 commits into from
May 12, 2024

Conversation

vvuk
Copy link
Collaborator

@vvuk vvuk commented May 11, 2024

This adds support for enabling the CoreCLR ETW provider and tracking events related to
JIT compilation, GC, and others if the --coreclr argument is used. There is also
a --coreclr-allocs, which will emit an event for every GC allocation (which is a lot).
(The allocation tracking doesn't emit the type name yet, just a type handle, but names
are coming.)

CoreCLR events are only currently useful if Samply launches the app; there's future work
coming to enable the CoreCLR "rundown" provider that provides all the necessary info
at the start of capture for existing processes. (Similar to the DCStart events; it's just
not enabled by default because it's very expensive, as it has to dump info about all JIT
methods already compiled etc.)

@vvuk vvuk requested a review from mstange May 11, 2024 00:02
@mstange
Copy link
Owner

mstange commented May 12, 2024

CoreCLR events are only currently useful if Samply launches the app;

Or when using samply record -a if the app starts after profiling starts, I assume.

@vvuk vvuk enabled auto-merge (squash) May 12, 2024 19:44
@vvuk vvuk merged commit 11faaec into main May 12, 2024
15 checks passed
@vvuk vvuk deleted the vladv/windows-coreclr branch May 12, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants