Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to Factorio v2 #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Akuukis
Copy link

@Akuukis Akuukis commented Oct 25, 2024

My first time modding Factorio so I don't know most of what I'm doing, but the mod works for me now! I ran the game, it crashed, I read the error message, searched for it in either of 3 docs, changed something. Repeated for few dozen times.

This is not a complete PR, it requires cleanup, version bump, and maybe fixing more problems that didn't crash the game. I don't have interest to finish this. Feel free to merge this or push to this or close this, whatever is convenient to you.

Jodokus31 said "I hope [upgrading is] straight forward". Hopefully this PR shows that it is and helps you to get started! :)

@Akuukis
Copy link
Author

Akuukis commented Oct 27, 2024

After playing for a day, it did work but not always. Around working machines it crashed with another error that I didn't dig into yet.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function flying_text.create_flying_text_entities(surface, position, flying_text_infos, player)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FlyingText.create_flying_text_entities(surface, position, flying_text_infos) -> FlyingText.create_flying_text_entities(surface, position, flying_text_infos, player)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete is_mining_tool in function is_special_stack(stack)

Copy link

@KingCTer KingCTer Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for name, itemData in pairs(inventory.get_contents()) do ->
for _, itemData in ipairs(inventory.get_contents()) do
local name = itemData.name
local count = itemData.count

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants