Huawei Mediapad T3 10: new device #454
Conversation
| /* | ||
| * This device is quirky. It excluded from generic build. | ||
| * To run lk2nd on this device you need to flash custom bootloader and unlock it. Read more https://wiki.postmarketos.org/wiki/Huawei_Mediapad_T3_10_(huawei-agassi)#Bootloader_unlocking. | ||
| * | ||
| * Compile lk2nd with the following flag to run on this device | ||
| * LK2ND_ADTBS="msm8917-huawei-agassi.dtb" | ||
| */ |
There was a problem hiding this comment.
I'd appreciate the comment to be folded at 80-100 where possible so it's a bit easier to read
| model = "Huawei MediaPad T3 10 (agassi)"; | ||
| compatible = "huawei,agassi"; | ||
| lk2nd,dtb-files = "msm8917-huawei-agassi"; | ||
| lk2nd,match-cmdline = "*androidboot.bootloader.version=P2200_DEFAULT_BOOTLOADER_170523*"; |
There was a problem hiding this comment.
I'm actually not sure if this is useful, perhaps could drop this and use LK2ND_COMPATIBLE="huawei,agassi" at build time additionally? This would force lk2nd to always find this node
lk2nd/device/dts/msm8952/rules.mk
Outdated
| @@ -16,3 +16,6 @@ ADTBS += \ | |||
| $(LOCAL_DIR)/msm8940-xiaomi-santoni.dtb \ | |||
| $(LOCAL_DIR)/msm8956-mtp.dtb \ | |||
| $(LOCAL_DIR)/msm8976-qrd.dtb \ | |||
|
|
|||
| DTBS += \ | |||
| $(LOCAL_DIR)/msm8917-huawei-agassi.dtb | |||
There was a problem hiding this comment.
| $(LOCAL_DIR)/msm8917-huawei-agassi.dtb | |
| $(LOCAL_DIR)/msm8917-huawei-agassi.dtb \ | |
let's always escape newlines so if we need to add anything it would not change old lines
Co-authored-by: Nikita Travkin <[email protected]>
|
Thanks! |
|
|
||
| / { | ||
| qcom,msm-id = <QCOM_ID_MSM8917 0>; | ||
| qcom,board-id = <QCOM_BOARD_ID(QRD, 1, 0) 0>; |
There was a problem hiding this comment.
I think here the file name doesn't really matter since this is a dtb that will only be manually included for that one device. We can rename it later if we have more here
|
|
||
| / { | ||
| qcom,msm-id = <QCOM_ID_MSM8917 0>; | ||
| qcom,board-id = <QCOM_BOARD_ID(QRD, 1, 0) 0>; |
There was a problem hiding this comment.
Looks like msm8917-pmi8937-qrd-sku5
No description provided.