Skip to content

Commit

Permalink
add a inventory online check skip list
Browse files Browse the repository at this point in the history
- test(test_api_good_nonlocal): provide explicit reasons to skip test
  • Loading branch information
msftcangoblowm committed Aug 29, 2024
1 parent eeed16d commit f9e9b28
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ changes.

#### Tests

* in tests/test_api_good_nonlocal.py provide explicit reasons test skip
* in test_api_inventory_many_url_imports, sequence of inventory file names to skip
* add resources objects_attrs_plus_one_entry.{txt|inv}
* compare existing resources. Rather modify then .txt --> .inv
* add fixtures res_cmp_plus_one_line is_linux gitconfig gitattributes
Expand Down
14 changes: 12 additions & 2 deletions tests/test_api_good_nonlocal.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,18 @@ def test_api_inventory_many_url_imports(
scr_fpath = scratch_path / fname

# Drop most unless testall
if not pytestconfig.getoption("--testall") and fname != "objects_attrs.inv":
pytest.skip("'--testall' not specified")
skips = (
"objects_attrs.inv",
"objects_attrs_plus_one_entry.inv",
)
is_not_testall = not pytestconfig.getoption("--testall")
if is_not_testall:
reason = "'--testall' not specified"
pytest.skip(reason)
is_skip = fname in skips
if is_skip:
reason = f"skip online checks for theis inventory {fname}"
pytest.skip(reason)

# Construct inventories for comparison
mch = misc_info.p_inv.match(fname)
Expand Down

0 comments on commit f9e9b28

Please sign in to comment.