Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new token refresh endpoint #220

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

edlea
Copy link
Contributor

@edlea edlea commented Feb 5, 2021

Tokens issued via the v3 OAuth2 flow need to be renewed via the v3 refresh endpoint.

Also update the new login flow to return the refresh token required (i.e. from "step 3" rather than "step 4") to successfully issue new tokens. The final JWT output has a refresh token too, but this seems not to be used and so is discarded.

Tokens issued via the v3 OAuth2 flow need to be renewed via the
v3 refresh endpoint.

Also update the new login flow to return the refersh token required
(i.e. from "step 3" rather than "step 4") to successfully issue new
tokens.
@edlea
Copy link
Contributor Author

edlea commented Feb 5, 2021

Looks like we need an Apiary stub for https://owner-api.teslamotors.com. I'll look at adding this

@nfarina
Copy link
Contributor

nfarina commented Nov 6, 2021

TeslaJS doesn't work at all for me without this patch! The existing refresh endpoint simply doesn't work with "v3" refresh tokens (which are the only ones you can get now).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is login.js returning incorrect refresh token?
3 participants