Skip to content

Commit

Permalink
Exclude WIP and draft PRs from tests
Browse files Browse the repository at this point in the history
  • Loading branch information
mrmundt committed Apr 2, 2024
1 parent a9b9112 commit 377dece
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 3 deletions.
8 changes: 8 additions & 0 deletions .github/workflows/test_pr_and_main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ on:
pull_request:
branches:
- main
types:
- opened
- reopened
- synchronize
- ready_for_review
workflow_dispatch:
inputs:
git-ref:
Expand Down Expand Up @@ -34,6 +39,9 @@ jobs:
lint:
name: lint/style-and-typos
runs-on: ubuntu-latest
if: |
${{ ! github.event.pull_request.draft &&
github.event.pull_request.title != *"WIP"* }}
steps:
- name: Checkout Pyomo source
uses: actions/checkout@v4
Expand Down
14 changes: 11 additions & 3 deletions doc/OnlineDocs/contribution_guide.rst
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,10 @@ at least 70% coverage of the lines modified in the PR and prefer coverage
closer to 90%. We also require that all tests pass before a PR will be
merged.

.. note::
If you are having issues getting tests to pass on your Pull Request,
please tag any of the core developers to ask for help.

The Pyomo main branch provides a Github Actions workflow (configured
in the ``.github/`` directory) that will test any changes pushed to
a branch with a subset of the complete test harness that includes
Expand All @@ -82,13 +86,17 @@ This will enable the tests to run automatically with each push to your fork.

At any point in the development cycle, a "work in progress" pull request
may be opened by including '[WIP]' at the beginning of the PR
title. This allows your code changes to be tested by the full suite of
Pyomo's automatic
testing infrastructure. Any pull requests marked '[WIP]' will not be
title. Any pull requests marked '[WIP]' or draft will not be
reviewed or merged by the core development team. However, any
'[WIP]' pull request left open for an extended period of time without
active development may be marked 'stale' and closed.

.. note::
Draft and WIP Pull Requests will **NOT** trigger tests. This is an effort to
keep our backlog as available as possible. Please liberally use the provided
branch testing for draft functionality.


Python Version Support
++++++++++++++++++++++

Expand Down

0 comments on commit 377dece

Please sign in to comment.