Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add vue file basic support, alias path, fix #79 #53 #101

Closed
wants to merge 3 commits into from

Conversation

yoyo930021
Copy link
Contributor

@yoyo930021 yoyo930021 commented Dec 11, 2019

Description

  1. Add .vue file basic support, refer to vetur for implementation. fix Support for vue files (variable suggestions, mixins etc.)  #66
  2. Use TextEdit to fix Intellisense autocomplete issue in latest build #79, because lsp spec write this:
The `insertText` is subject to interpretation by the client side.
Some tools might not take the string literally. For example
VS Code when code complete is requested in this example `con<cursor position>`
and a completion item with an `insertText` of `console` is provided itwill only insert `sole`. Therefore it is recommended to use `textEdit` instead
since it avoids additional client side interpretation.
  1. Add resolve alias path on config, and fix resolve error node_modules path. Implicit import finding wrong file #53

TODO

  • add more test

@mrmlnc
Copy link
Owner

mrmlnc commented Dec 12, 2019

Thanks for the contribution! I really appreciate it. 🎉

Can you divide this pull request into several by the number of issues being fixed? For example, I am now ready to accept a bug fix for #79, but not ready to accept a new option without investigation from my side.

@yoyo930021
Copy link
Contributor Author

yoyo930021 commented Dec 12, 2019

@yoyo930021 yoyo930021 closed this Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intellisense autocomplete issue in latest build Support for vue files (variable suggestions, mixins etc.)
2 participants