Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix role to allow jinja2_native=True #232

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Conversation

mcpovel
Copy link
Contributor

@mcpovel mcpovel commented Oct 30, 2024

Some types will get converted when jinja2_native is set

Description

There were some strings converted to int when jinja2_native is true. Also the list generated contained the return value of append "NONE" These were change a leats for the ubuntu/debian

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@eRadical eRadical requested a review from elcomtik October 30, 2024 13:53
@eRadical
Copy link
Collaborator

LGTM, @elcomtik - thoughts?

@elcomtik
Copy link
Collaborator

elcomtik commented Nov 4, 2024

LGTM

@eRadical
Copy link
Collaborator

eRadical commented Nov 8, 2024

@mcpovel - I see only debian files are fixed, can you, please, also look into other distros?

@mcpovel
Copy link
Contributor Author

mcpovel commented Nov 8, 2024

As far as I can see only the debian is using the 0x000 Hex key which failed. For the other distros only the port calculation and the list generation should apply. But I had no chance to test.

@eRadical
Copy link
Collaborator

@mcpovel - linting is failing because of spaces at EOF in two files.

After you fix this I'll merge.
10x

@eRadical eRadical merged commit 2523590 into mrlesmithjr:master Nov 12, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants