Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make log_error configurable #229

Conversation

andanotheruser
Copy link
Contributor

Description

This makes the path for log_error configurable. :)

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly. (README.md? Please specify what documentation exactly.)
  • I have added tests to cover my changes. (No changes required here)
  • All new and existing tests passed.

@eRadical
Copy link
Collaborator

@andanotheruser - some tests failed, can you please look why?

@andanotheruser andanotheruser force-pushed the upstreaming-make-log-error-configurable branch from 708a9f5 to 326be54 Compare November 14, 2024 10:23
@andanotheruser andanotheruser force-pushed the upstreaming-make-log-error-configurable branch from 326be54 to c68dbc9 Compare November 14, 2024 11:41
@andanotheruser
Copy link
Contributor Author

@andanotheruser - some tests failed, can you please look why?

Single character that should not have been there, fixed it

@eRadical eRadical merged commit 0fbfc23 into mrlesmithjr:master Nov 14, 2024
8 of 9 checks passed
@eRadical
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants