Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to upgrade packages when allowed by mariadb_upgrade #226

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

elcomtik
Copy link
Collaborator

@elcomtik elcomtik commented Oct 3, 2024

Allow upgrading packages when allowed by mariadb_upgrade

Description

I observed that when I wanted to upgrade from old MariaDB 10.6 to the current default 10.11, not even setting mariadb_upgrade=True was sufficient to upgrade packages when they were already installed on my system.

So I introduced logic, which allows to update packages when the user wants to upgrade.

This is potentionally dangerous and testing is advised for any upgrades on the production database.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@elcomtik elcomtik requested a review from eRadical October 3, 2024 15:00
@elcomtik
Copy link
Collaborator Author

elcomtik commented Oct 3, 2024

@eRadical can you take a look at code in my PR?

@eRadical
Copy link
Collaborator

eRadical commented Oct 4, 2024

Can you also add in debian.yml ?

Or maybe take task out of redhat/debian as it is not different!

@elcomtik
Copy link
Collaborator Author

elcomtik commented Oct 4, 2024

OK, I extracted the package install into its own file and included it in both debian/redhat.

@eRadical eRadical merged commit a83a130 into mrlesmithjr:master Oct 4, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants