Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Fully Qualified Collection Name (FQCN) ansible tasks #201

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

roumano
Copy link
Contributor

@roumano roumano commented Mar 1, 2024

Description

Use all tasks with FQCN name tasks

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@eRadical
Copy link
Collaborator

eRadical commented Mar 1, 2024

Hi @roumano & thank you for this - it was on my mind also.

As this might be backward incompatible I need input from @mrlesmithjr & @elcomtik.

So - @mrlesmithjr & @elcomtik - thoughts?

@elcomtik
Copy link
Collaborator

elcomtik commented Mar 1, 2024

I thought that we had already migrated to FQCN and newer Ansible. Ansible 2.9 is no longer supported so I'm definitely for making this breaking change.

A long time ago I did that for another role from mrlesmithjr (frr) and we bumped ansible to version 7. I would choose the current Ansible version, at time of writing version 9.

@mrlesmithjr
Copy link
Owner

You all make my work so much easier ;) In all seriousness, I truly appreciate all of you!

@eRadical
Copy link
Collaborator

eRadical commented Mar 3, 2024

My plan is first to merge this.

I'll make another PR where I'll change the min requirements - we must also bump up python to 3.10.

After this we need @mrlesmithjr to "release" a new version - either "v0.4.0" or go full with "v1" :)

@eRadical eRadical merged commit 1aa179d into mrlesmithjr:master Mar 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants