minor changes for better Qt6 compatibility #368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it seems qmake shipped with Qt6 ignores `CONFIG += c++14` and as result no `-std` compiler option is set, hence it falls back to the default standard supported by compiler, which is C++17 nowadays in many cases (at least since GCC 11) on macOS it seems C++17 is enforced by Qt (C++98 by default)
it seems QAction was moved from QtWidgets to QtGUI in Qt6, fortunately, required correct header is included into the header generated from .ui file, so no need to include it explicitly in .cpp QActionGroup seems no longer implicitly included with QMenu or whatever, so need to include it explicitly
QStringRef is no longer a part of Qt API since Qt6 (but still available in Qt5Compat module) there is no particular reason nor significant benefit in its usage in this particular (and just single) case, so replace it with regular substring operation (aka `QString::mid()`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commits description for details