change order of merge in FFScore to maintain sorted rankings

mrjleo · Dec 15, 2024 · 83ab446 · 83ab446
1 parent ee8b74d
commit 83ab446
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/fast_forward/util/pyterrier.py b/src/fast_forward/util/pyterrier.py
@@ -40,10 +40,10 @@ def transform(self, inp: "pd.DataFrame") -> "pd.DataFrame":
             )
         )._df.rename(columns={"q_id": "qid", "id": "docno"})
 
-        result = inp[["qid", "docno", "score"]].merge(
-            ff_scores[["qid", "docno", "score", "query"]],
+        result = ff_scores[["qid", "docno", "score", "query"]].merge(
+            inp[["qid", "docno", "score"]],
             on=["qid", "docno"],
-            suffixes=("_0", None),
+            suffixes=(None, "_0"),
         )
         return pt.model.add_ranks(result, single_query=False)