Minor enhancements

### UPDATED - Better detection of unknown orb security button collections and sensors status. v3.2.11
mrjackyliang · Mar 12, 2024 · 8d9a245 · 8d9a245
1 parent 93ac54e
commit 8d9a245
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 7 deletions.
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "homebridge-adt-pulse",
   "displayName": "Homebridge ADT Pulse",
-  "version": "3.2.10",
+  "version": "3.2.11",
   "description": "Homebridge security system platform for ADT Pulse",
   "main": "./build/index.js",
   "exports": "./build/index.js",

diff --git a/src/lib/detect.ts b/src/lib/detect.ts
@@ -95,11 +95,11 @@ import type {
 export async function detectApiDebugParser(data: DetectApiDebugParserData, logger: DetectApiDebugParserLogger, debugMode: DetectApiDebugParserDebugMode): DetectApiDebugParserReturns {
   const forceArmHandlerAnomaly = data.method === 'forceArmHandler' && isUnknownDoSubmitHandlerCollection(data.response);
   const getGatewayInformationAnomaly = data.method === 'getGatewayInformation' && isUnknownGatewayDevice(data.response);
-  const getOrbSecurityButtonsAnomaly = data.method === 'getOrbSecurityButtons' && isUnknownOrbSecurityButtonCollection(data.response);
+  const getOrbSecurityButtonsAnomaly = data.method === 'getOrbSecurityButtons' && isUnknownOrbSecurityButtonCollection(data.response) && !data.rawHtml.includes('Status Unavailable.');
   const getPanelInformationAnomaly = data.method === 'getPanelInformation' && isUnknownPanelDevice(data.response);
   const getPanelStatusAnomaly = data.method === 'getPanelStatus' && isEmptyOrbTextSummary(data.response);
   const getSensorsInformationAnomaly = data.method === 'getSensorsInformation' && data.response.length < 1;
-  const getSensorsStatusAnomaly = data.method === 'getSensorsStatus' && data.response.length < 1;
+  const getSensorsStatusAnomaly = data.method === 'getSensorsStatus' && data.response.length < 1 && !data.rawHtml.includes('Status Unavailable.');
 
   if (
     forceArmHandlerAnomaly

diff --git a/src/lib/items.ts b/src/lib/items.ts
@@ -154,10 +154,6 @@ export const collectionOrbSecurityButtons: CollectionOrbSecurityButtons = [
       },
     ],
   },
-  {
-    description: 'System unavailable',
-    buttons: [],
-  },
 ];
 
 /**
-Original file line number
+Diff line change
@@ Expand Up @@
           },
         ],
       },
-      {
-        description: 'System unavailable',
-        buttons: [],
-      },
     ];
     /**
@@ Expand Down @@