Skip to content

Commit

Permalink
Performance improvements and fixes
Browse files Browse the repository at this point in the history
### UPDATED
- Renamed `AxiosResponseWithRequest` to `AxiosResponseNodeJs` for better clarity.
- Switched from assert JSON import for ESM to `createRequire` because method is still experiemental.
- Consolidated detect report url to one place.
- Reduced the import of alias types, where the types would directly point to another file.
- After the plugin removes all related accessories (reset mode), the log should be `info`, not `warn`.
- Fetching accessory statuses for the "status" mode is now moved to the bottom to better accomodate other optional characteristics.
- "Status Tampered" for security panels now temporarily set to "Not Tampered" until there are enough statuses to determine a tamper.

### FIXED
- Sensors and panel status would not be refreshed unless the user forces the retrieval and/or refresh manually (credits to @NorthernMan54).
- If accessories were removed from config, this may cause a array out of bounds error due to the loop iterating forwards, not backwards.
- "Status Active" for sensors improperly detecting statuses and icons.

### ADDED
- Support for "Heat (Rate-of-Rise) Detector" sensor.
- `sensor-mismatch` type for `stackTracer` in events where the data responses of `sensorInfo` and `sensorStatus` are not the same.
- Unknown information dispatcher in `ADTPulsePlatform` in attempts to improve better collection of undocumented sensor statuses.
- A notice for users if they upgraded from `v2` to `v3` to update their configuration.
- Attempt to ask `axios` or portal to not cache responses.

### REMOVED
- Is portable accessible (internet check) due to redundancy and performance bottleneck.
- New information dispatcher in `ADTPulseAccessory`.
- Description in body for when the detector sends information to plugin author since it's redundant.
  • Loading branch information
mrjackyliang committed Jan 7, 2024
1 parent 76e3a92 commit 7713850
Show file tree
Hide file tree
Showing 13 changed files with 542 additions and 630 deletions.
15 changes: 8 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,14 @@ This plugin can expose these devices (in read-only mode) based on your configura
3. `fire` - Fire (Smoke/Heat) Detector
4. `flood` - Water/Flood Sensor
5. `glass` - Glass Break Detector
6. `keypad` - Keypad/Touchpad
7. `motion` - Motion Sensor __::__ Motion Sensor (Notable Events Only)
8. `panic` - Audible Panic Button/Pendant __::__ Silent Panic Button/Pendant
9. `shock` - Shock Sensor
10. `supervisory` - System/Supervisory
11. `temperature` - Temperature Sensor
12. `unknown` - Unknown Device Type
6. `heat` - Heat (Rate-of-Rise) Detector
7. `keypad` - Keypad/Touchpad
8. `motion` - Motion Sensor __::__ Motion Sensor (Notable Events Only)
9. `panic` - Audible Panic Button/Pendant __::__ Silent Panic Button/Pendant
10. `shock` - Shock Sensor
11. `supervisory` - System/Supervisory
12. `temperature` - Temperature Sensor
13. `unknown` - Unknown Device Type

Due to implementation complexity and platform instability, all Z-Wave accessories connected to the ADT Pulse gateway will not be planned for development or be supported overall. Consider purchasing the [Hubitat Hub](https://hubitat.com) for a seamless setup experience, or read about the [Home Assistant Z-Wave](https://www.home-assistant.io/integrations/zwave_js/) integration.

Expand Down
6 changes: 6 additions & 0 deletions config.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,12 @@
"glass"
]
},
{
"title": "Heat (Rate-of-Rise) Detector",
"enum": [
"heat"
]
},
{
"title": "Keypad/Touchpad",
"enum": [
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "homebridge-adt-pulse",
"displayName": "Homebridge ADT Pulse",
"version": "3.0.0-beta.19",
"version": "3.0.0-beta.20",
"description": "Homebridge security system platform for ADT Pulse",
"main": "./build/src/index.js",
"exports": "./build/src/index.js",
Expand Down
Loading

0 comments on commit 7713850

Please sign in to comment.