Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSL: Support defined color spaces in ColorSpaceNode #29694

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
+34 −74
Open

TSL: Support defined color spaces in ColorSpaceNode #29694

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa52755
TSL: Support defined color spaces in ColorSpaceNode
donmccurdy Oct 19, 2024
bbaf388
TSL: Add .convertColorNode()
donmccurdy Oct 19, 2024
df8973a
fix circular dependency
sunag Oct 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/nodes/display/ColorSpaceNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,12 @@ export const toWorkingColorSpace = ( node ) => nodeObject( new ColorSpaceNode( n
export const workingToColorSpace = ( node, colorSpace ) => nodeObject( new ColorSpaceNode( nodeObject( node ), WORKING_COLOR_SPACE, colorSpace ) );
export const colorSpaceToWorking = ( node, colorSpace ) => nodeObject( new ColorSpaceNode( nodeObject( node ), colorSpace, WORKING_COLOR_SPACE ) );

export const convertColorSpace = ( node, sourceColorSpace, targetColorSpace ) => nodeObject( new ColorSpaceNode( nodeObject( node ), sourceColorSpace, targetColorSpace ) );

addMethodChaining( 'toOutputColorSpace', toOutputColorSpace );
addMethodChaining( 'toWorkingColorSpace', toWorkingColorSpace );

addMethodChaining( 'workingToColorSpace', workingToColorSpace );
addMethodChaining( 'colorSpaceToWorking', colorSpaceToWorking );

addMethodChaining( 'convertColorSpace', convertColorSpace );
Copy link
Collaborator

@sunag sunag Oct 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have plans to have the color space information present in the flow of code, that way we will always know what the color space source of the current value. I was thinking about adding a node.toColorSpace( targetColorSpace ) function in the method chaining.

Maybe we could reverse the order to:

addMethodChaining( 'toColorSpace', ( node, targetColorSpace, sourceColorSpace = null  ) => convertColorSpace( node, sourceColorSpace, targetColorSpace ) );

Thinking about the future... Or maybe just remove this method from chaning for now?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have plans to have the color space information present in the flow of code ... adding a node.toColorSpace( targetColorSpace

That sounds like a good idea to me.

And in addition, consider adding .colorSpace as a property of the Color class.

Loading