Addons: WebGPU CSM shadows - using shadowNode #29610
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
It seems toggling the |
|
|
|
I get the same errors on Chrome WebGL. Appears to be an issue with vec2[4] cascades array. Hardcoding a vec2() rather than cascades.element( n ) in the shader removes the error and is equivalent to how the original PR worked. Looking at the issue at the moment. |
|
The WebGL version works now 🎉 . During testing, I have noticed that when using a WebGL backend and an orthographic camera, the shadows start with an offset:
|
Fix main frustum with WebGL backend.
|
I have fixed the issue with the WebGL backend and orthographic cameras via b441f99. |
|
Fading is still broken though. Not sure where the root cause is yet... The |
|
What is the exact issue with fading? Apart from requiring toggling shadow on and off to get the material to rebuild. |
|
When you turn Without fading: 
With fading: 
In the |
|
Fixed up the fading now |
| import { reference, uniform, int, float, vec4, vec2, If, Fn, min, renderGroup, positionView, Node, NodeUpdateType, shadow } from 'three/tsl'; | ||
|
|
||
| const _cameraToLightMatrix = new Matrix4(); | ||
| const _lightSpaceFrustum = new CSMFrustum(); |
There was a problem hiding this comment.
I think you must create CSMFrustum depending on the backend. Otherwise the result is incorrect for WebGL since the internal vertices are not correctly configured.
| @@ -8,6 +8,8 @@ class CSMFrustum { | |||
|
|
|||
| data = data || {}; | |||
|
|
|||
| this.zNear = data.webGL === true ? - 1 : 0; | |||
There was a problem hiding this comment.
CSMFrustum creates internal instances of CSMFrustum but without honoring the data parameter (see line 87).
It seems data must be a property so you can pass it later to the ctor.
| csmDirectionalLight.shadow.mapSize.width = 1024; | ||
| csmDirectionalLight.shadow.mapSize.height = 1024; | ||
| csmDirectionalLight.shadow.camera.near = 1; | ||
| csmDirectionalLight.shadow.camera.far = 20000; |
There was a problem hiding this comment.
Why did you pick this extreme far value? I would expect using 1000 (params.far).
Related issue: #29295
CSM implemented using shadowNode.
This uses dummy light objects to use the existing mechanism for updating the cascades shadow cameras, without injecting additional lights into the scene.
The original csm.lightDirection is replaced by the
DirectionalLights direction and shadow parameters are inherited from the lights shadow object.This issue where switching between fade and non-fade modes requires triggering a rebuild by disabling and reenabling shadows remains.