Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode links #25099

Merged
merged 2 commits into from
Dec 12, 2022
Merged

Unicode links #25099

merged 2 commits into from
Dec 12, 2022

Conversation

bergden-resonai
Copy link
Contributor

Related issue: #25098

Description
I started working on Hebrew translation to the docs, and noticed some issues with RTL support and links which use non-[a-zA-Z] characters
It's a pretty big change and there are potentially many follow-up tasks such as:

  • Decide if to also allow unicode characters in the href part (need to add % and \p{L} there as well)
  • Decide whether to carry this change to other templates (I think that's not relevant, unless the URLs of three.js pages would also be localized, which is not a good idea IMO)
  • Find and replace all occurrences where the author localized the link and opted to use inline tags (for example)

The code blocks looks like this currently:
image
The single line blocks are fine, the multi-line blocks and not-unreadable but are not as nice

This contribution is funded by Resonai

docs/page.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants