Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update type hint to make compatible with interface #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update type hint to make compatible with interface #13

wants to merge 1 commit into from
+1 −1

Conversation

bwaters
Copy link

@bwaters bwaters commented Apr 6, 2023

This fixes a fatal error with Minify: 3.0.13 and php 8.1

Fatal error: Declaration of Props\Container::has($name) must be compatible with Psr\Container\ContainerInterface::has(string $id): bool in /var/www/html/vendor/mrclay/props-dic/src/Props/Container.php on line 105

@bwaters bwaters mentioned this pull request Apr 6, 2023
Open
glensc
glensc reviewed Apr 6, 2023
View reviewed changes
src/Props/Container.php
@@ -102,7 +102,7 @@ public function __isset($name)
/**
* {@inheritdoc}
*/
public function has($name)
public function has($name): bool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this backward compatible with psr/container 1.1.2?

@Zmaon
Copy link

Zmaon commented May 23, 2023

Could someone create a release with this fix? The issue is really blocking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glensc glensc glensc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwaters @Zmaon @glensc