-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auslagerung des Zugriffs auf Thresholds in eigene Klasse #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nduce_rule" of the class RuleInduction.
5 tasks
…sImpl::ThresholdsSubsetImpl.
…ntCallback (filtering is still missing).
…o the constructor of the class RuleRefinementCallback.
…csTarget_" to "coveredExamplesMask_" and "coveredExamplesTarget_".
… class ExactThresholdsImpl::ThresholdsSubsetImpl.
…covered_examples".
…ute "bestRefinement_".
michael-rapp
changed the title
WIP: Auslagerung des Zugriffs auf Thresholds in eigene Klasse
Auslagerung des Zugriffs auf Thresholds in eigene Klasse
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lagert den Zugriff auf die Thresholds, die von den Bedingungen einer Regel potentiell genutzt werden können, in eine eigene abstrakte Basisklasse
AbstractThresholds
aus. Der Zugriff auf die exakten Thresholds, die bisher vom Algorithmus genutzt werden, erfolgt durch die ImplementierungExactThresholdsImpl
.Die Klasse
AbstractThresholds
besitzt eine FunktioncreateSubset
, die ein Objekt vom TypIThresholdsSubset
zurückgibt. Ein solches Objekt erlaubt es mittels der FunktioncreateRuleRefinement
die möglichen Refinements einer Regel zu evaluieren, mittels der FunktionapplyRefinement
ein Refinement anzuwenden und die Thresholds dementsprechend zu filtern, die Vorhersagen eines zuvor gefundenen Refinements mitrecalculatePrediction
auf Basis aller Trainingsbeispiele neu zu berechnen und eine finale Regel mitapplyPrediction
anzuwenden.Achtung: Die Möglichkeit Regeln zu prunen wird durch diesen Pull-Request vorübergehend deaktiviert.