Remove field "order_" from class OrdinalFeatureVector.

mrapp-ke · Oct 12, 2023 · bd6e435 · bd6e435
1 parent 03c75fb
commit bd6e435
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 60 deletions.
diff --git a/cpp/subprojects/common/include/mlrl/common/input/feature_vector_ordinal.hpp b/cpp/subprojects/common/include/mlrl/common/input/feature_vector_ordinal.hpp
@@ -10,10 +10,6 @@
  * value, i.e., the most frequent value, of an ordinal feature.
  */
 class OrdinalFeatureVector : public NominalFeatureVector {
-    private:
-
-        uint32* order_;
-
     public:
 
         /**
@@ -23,39 +19,4 @@ class OrdinalFeatureVector : public NominalFeatureVector {
          * @param majorityValue The majority value, i.e., the most frequent value, of the ordinal feature
          */
         OrdinalFeatureVector(uint32 numValues, uint32 numExamples, int32 majorityValue);
-
-        ~OrdinalFeatureVector() override;
-
-        /**
-         * Returns an `index_iterator` to the beginning of the ordered indices of the values of the ordinal feature.
-         *
-         * @param index The index of the value
-         * @return      An `index_iterator` to the beginning
-         */
-        index_iterator order_begin(uint32 index);
-
-        /**
-         * Returns an `index_iterator` to the end of the ordered indices of the values of the ordinal feature.
-         *
-         * @param index The index of the value
-         * @return      An `index_iterator` to the end
-         */
-        index_iterator order_end(uint32 index);
-
-        /**
-         * Returns an `index_const_iterator` to the beginning of the ordered indices of the values of the ordinal
-         * feature.
-         *
-         * @param index The index of the value
-         * @return      An `index_const_iterator` to the beginning
-         */
-        index_const_iterator order_cbegin(uint32 index) const;
-
-        /**
-         * Returns an `index_const_iterator` to the end of the ordered indices of the values of the ordinal feature.
-         *
-         * @param index The index of the value
-         * @return      An `index_const_iterator` to the end
-         */
-        index_const_iterator order_cend(uint32 index) const;
 };
diff --git a/cpp/subprojects/common/src/mlrl/common/input/feature_vector_ordinal.cpp b/cpp/subprojects/common/src/mlrl/common/input/feature_vector_ordinal.cpp
@@ -1,24 +1,4 @@
 #include "mlrl/common/input/feature_vector_ordinal.hpp"
 
 OrdinalFeatureVector::OrdinalFeatureVector(uint32 numValues, uint32 numExamples, int32 majorityValue)
-    : NominalFeatureVector(numValues, numExamples, majorityValue), order_(new uint32[numValues]) {}
-
-OrdinalFeatureVector::~OrdinalFeatureVector() {
-    delete[] order_;
-}
-
-OrdinalFeatureVector::index_iterator OrdinalFeatureVector::order_begin(uint32 index) {
-    return order_;
-}
-
-OrdinalFeatureVector::index_iterator OrdinalFeatureVector::order_end(uint32 index) {
-    return &order_[this->getNumElements()];
-}
-
-OrdinalFeatureVector::index_const_iterator OrdinalFeatureVector::order_cbegin(uint32 index) const {
-    return order_;
-}
-
-OrdinalFeatureVector::index_const_iterator OrdinalFeatureVector::order_cend(uint32 index) const {
-    return &order_[this->getNumElements()];
-}
+    : NominalFeatureVector(numValues, numExamples, majorityValue) {}