Use keywords "static inline constexpr" for constants, if possible.

mrapp-ke · Aug 18, 2024 · 89ff88b · 89ff88b
1 parent 01bed30
commit 89ff88b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/cpp/subprojects/boosting/src/mlrl/boosting/losses/loss_decomposable_sparse_common.hpp b/cpp/subprojects/boosting/src/mlrl/boosting/losses/loss_decomposable_sparse_common.hpp
@@ -12,7 +12,7 @@
 
 namespace boosting {
 
-    static const uint32 LIMIT = std::numeric_limits<uint32>::max();
+    static inline constexpr uint32 LIMIT = std::numeric_limits<uint32>::max();
 
     template<typename IndexIterator>
     static inline uint32 fetchNextStatistic(IndexIterator& indexIterator, IndexIterator indicesEnd,

diff --git a/cpp/subprojects/common/include/mlrl/common/data/view_matrix_sparse_set.hpp b/cpp/subprojects/common/include/mlrl/common/data/view_matrix_sparse_set.hpp
@@ -259,7 +259,7 @@ class MLRLCOMMON_API SparseSetView
         /**
          * The index that is used to indicate that the value at a specific row and column is zero.
          */
-        static const uint32 MAX_INDEX = std::numeric_limits<uint32>::max();
+        static inline constexpr uint32 MAX_INDEX = std::numeric_limits<uint32>::max();
 
     public:
-Original file line number
+Diff line change
@@ Expand Up / @@ -259,7 +259,7 @@ class MLRLCOMMON_API SparseSetView @@
             /**
              * The index that is used to indicate that the value at a specific row and column is zero.
              */
-            static const uint32 MAX_INDEX = std::numeric_limits<uint32>::max();
+            static inline constexpr uint32 MAX_INDEX = std::numeric_limits<uint32>::max();
         public:
@@ Expand Down @@